Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

fix: :bug: Fix bug in compile_rust_files where it returns a list of t…

Open Kade-Powell opened this issue 1 year ago • 2 comments

This PR fixes a bug in the reloader module's EventHandler class.

Description The Bug observed is when reloading the existing code, the compile_rust_files returned a list of the source files for any rust modules. when returned the EventHandler set those files as self.built_rust_binaries so when clean_rust_binaries ran it deleted the source files for rust modules and did not delete the binary.

Instead i fixed the return statement in compile_rust_files to return all matching binaries so the correct item will be deleted on reload and no the source code files.

This PR fixes # - I did not open an issue for this

Kade-Powell avatar Jun 26 '24 18:06 Kade-Powell

Someone is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 26 '24 18:06 vercel[bot]

CodSpeed Performance Report

Merging #873 will not alter performance

Comparing Kade-Powell:rust_file_cleaning_fix (18a3cc0) with main (a04a3d5)

Summary

✅ 110 untouched benchmarks

codspeed-hq[bot] avatar Jun 26 '24 18:06 codspeed-hq[bot]

@VishnuSanal , could you have a look at this?

sansyrox avatar Jul 01 '24 18:07 sansyrox

Hey @Kade-Powell 👋

Could you please write the steps that you used to test the code?

sansyrox avatar Jul 03 '24 22:07 sansyrox

Sure,

  1. Replace code from Python package in local environment with the changes I made in the PR.

  2. Run dev command and watch file tree to see if the source files were deleted or the binaries.

Kade-Powell avatar Jul 04 '24 01:07 Kade-Powell

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:56pm

vercel[bot] avatar Jul 31 '24 21:07 vercel[bot]

Hey @Kade-Powell 👋

You can try v0.58.2 . It is fixed now

sansyrox avatar Aug 07 '24 13:08 sansyrox