fix: :bug: Fix bug in compile_rust_files where it returns a list of t…
This PR fixes a bug in the reloader module's EventHandler class.
Description
The Bug observed is when reloading the existing code, the compile_rust_files returned a list of the source files for any rust modules. when returned the EventHandler set those files as self.built_rust_binaries so when clean_rust_binaries ran it deleted the source files for rust modules and did not delete the binary.
Instead i fixed the return statement in compile_rust_files to return all matching binaries so the correct item will be deleted on reload and no the source code files.
This PR fixes # - I did not open an issue for this
Someone is attempting to deploy a commit to the sparckles Team on Vercel.
A member of the Team first needs to authorize it.
CodSpeed Performance Report
Merging #873 will not alter performance
Comparing Kade-Powell:rust_file_cleaning_fix (18a3cc0) with main (a04a3d5)
Summary
✅ 110 untouched benchmarks
@VishnuSanal , could you have a look at this?
Hey @Kade-Powell 👋
Could you please write the steps that you used to test the code?
Sure,
-
Replace code from Python package in local environment with the changes I made in the PR.
-
Run dev command and watch file tree to see if the source files were deleted or the binaries.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| robyn | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 31, 2024 9:56pm |
Hey @Kade-Powell 👋
You can try v0.58.2 . It is fixed now