Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

[BUG] The --dev flag not working on Windows

Open sansyrox opened this issue 3 years ago • 2 comments

Description

--dev flag not working on windows

Traceback (most recent call last): File "C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\integration_tests\base_routes.py", line 209, in <module> app.start(port=ROBYN_PORT, url=ROBYN_URL) File "\\?\C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\robyn\__init__.py", line 163, in start event_handler.start_server_first_time() File "\\?\C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\robyn\dev_event_handler.py", line 14, in start_server_first_time self.processes.append(subprocess.Popen(["python3", self.file_name], start_new_session=False)) File "C:\Users\Gaurav Bhattacharjee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 969, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "C:\Users\Gaurav Bhattacharjee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1438, in _execute_child hp, ht, pid, tid = _winapi.CreateProcess(executable, args, FileNotFoundError: [WinError 2] The system cannot find the file specified

To replicate this issue: pytest -s integration_tests . You will see two tests failing.

Expected Behavior

The tests should not fail. 😄

Screenshots

Environment:

  • Host OS: Windows

[Optional] Additional Context


sansyrox avatar Sep 15 '22 00:09 sansyrox

Hey @sansyrox I am interested in taking this up :) Will look into this issue soon

guilefoylegaurav avatar Sep 15 '22 19:09 guilefoylegaurav

Thanks @guilefoylegaurav . Let me know if you require any suport/information from my end :smile:

sansyrox avatar Sep 15 '22 22:09 sansyrox

@sansyrox I am sorry, could not update you on this - stuck with mid-terms for 4 days. Shall get back to this soon.

guilefoylegaurav avatar Sep 24 '22 13:09 guilefoylegaurav

Hi @guilefoylegaurav , No worries. Take your time 😄

Also, all the best with your mid-terms! ✨

sansyrox avatar Sep 24 '22 15:09 sansyrox

@sansyrox with reference to the problem of hot reload mode not reflecting instant changes in (some, including mine) windows/linux machines, did you look into this?

Hi @guilefoylegaurav , thanks for your PR.

I don't have an access to a windows machine till the 26th so can't really tell you about the windows issue.

Dev server reflects the right changes on my osx machine but is not killed properly on KeyboardInterrupt. I will check my linux PC to give you updates about the debian state.

If the same problem persists, feel free to let me know, I shall investigate and explore further.

guilefoylegaurav avatar Oct 27 '22 10:10 guilefoylegaurav

@guilefoylegaurav , I didn't get a chance to have a look at it yet. Would you like have a look at it?

sansyrox avatar Oct 29 '22 05:10 sansyrox

Sure

guilefoylegaurav avatar Oct 29 '22 10:10 guilefoylegaurav