Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

Robyn's speed can be improved imo

Open sansyrox opened this issue 3 years ago • 3 comments

https://docs.rs/http_router/0.1.0/http_router/index.html

This package populates the macros, which are also thread-safe. So, releasing and acquiring RwLock should not be a bottleneck anymore.

Can try this.

sansyrox avatar Jan 23 '22 18:01 sansyrox

Cloning an Arc makes little sense if we want to use a RwLock. Can try to get rid of it.

https://stackoverflow.com/questions/33116317/when-would-you-use-a-mutex-without-an-arc

sansyrox avatar Jan 23 '22 18:01 sansyrox

Partial fix at : https://github.com/sansyrox/robyn/pull/156

sansyrox avatar Jan 25 '22 22:01 sansyrox

https://github.com/squeaky-pl/japronto/blob/master/src/japronto/router/analyzer.py#L43

Have a look at this implementation.

sansyrox avatar Jun 09 '22 09:06 sansyrox