Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

refactor: necessary refactoring of pyproject.toml

Open thePromger opened this issue 5 months ago • 8 comments

  • Adds requires-python tag/attributes which helps users+build_tool/pip to find minimum version supported

  • Changes version constraint from exact to lowest version supported to be used

  • Adding uv.lock file to be used in CI/CD or for development by some other maintainers

PR Checklist

Please ensure that:

  • [x] The PR contains a descriptive title
  • [x] The PR contains a descriptive summary of the changes
  • [x] You build and test your changes before submitting a PR.
  • [ ] You have added relevant documentation
  • [ ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

thePromger avatar Aug 07 '25 18:08 thePromger

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 5:36pm

vercel[bot] avatar Aug 07 '25 18:08 vercel[bot]

✨ No files to analyze in this PR.

Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9

recurseml[bot] avatar Aug 07 '25 18:08 recurseml[bot]

@sansyrox i might need to update some dependencies, should i update them in this PR itself or create new one? To update project/dev/test dependencies.

thePromger avatar Aug 07 '25 18:08 thePromger

CodSpeed Performance Report

Merging #1232 will degrade performances by 25.45%

Comparing thePromger:chng-toml (6733c28) with main (d29608d)

:tada: Hooray! pytest-codspeed just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability :partying_face:! Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 2 regressions
✅ 148 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_exception_handling[/sync/get/no_dec-get] 4.7 ms 5.6 ms -16.18%
test_basic_get[/sync/dict-sync dict get-sync-dict] 4.7 ms 6.3 ms -25.45%

codspeed-hq[bot] avatar Aug 07 '25 18:08 codspeed-hq[bot]

Did these change, because i saw in many big projects that they dont put upper bound limit for deps instead they just define lower bound limit supported, later i am able to understand the reason little bit. If we dont pin the exact version, so pip can download the dep according to host's os+python requirements which have many advantages than pinning exact version.

thePromger avatar Aug 07 '25 18:08 thePromger

@thePromger , update them here :D

sansyrox avatar Aug 08 '25 14:08 sansyrox

@sansyrox do read more about it, why codspeed performance dropped? https://github.com/CodSpeedHQ/pytest-codspeed/releases

CodSpeed Performance Report

Merging #1232 will degrade performances by 25.45%

what i am able to understand that this 25% performance drop is due to because we unpin the exact version, which allows pip to use latest version supported by host requirements and from pytest-codspeed==3.0.0 something they introduced new way of measuring/benchmark method known as wall time and from that version its set by default and to use that new method, we need to do some setup/changes like using their own runners and some other requirements too

let me test some senarious in robyn's CI inside this PR itself

thePromger avatar Aug 08 '25 17:08 thePromger

@sansyrox locally both codspeed-mode={instrumentation,walltime} both are working fine today, but i don't know what is the issue in CI note: yesterday, i think when used walltime (it took high cpu usage + every test takes very much longer time) in codespaces(i received the notification from them) and when defined mode as instrumentation it worked smoothly without any lags/delays.

thePromger avatar Aug 08 '25 17:08 thePromger