Robyn
Robyn copied to clipboard
Rust 1.83 causing warnings in "maturin develop"
Bug Description
I just updated to Rust 1.83.0 now my build is getting lots of these warnings
warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> src/server.rs:62:1
|
62 | #[pymethods]
| -^^^^^^^^^^^
| |
| `PyClassImplCollector` is not local
| `PyClassNewTextSignature` is not local
| move the `impl` block outside of this function `trampoline` and up 4 bodies
63 | impl Server {
| ------
| |
| `Server` is not local
| `Server` is not local
|
= note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed
= note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros`
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: `#[warn(non_local_definitions)]` on by default
= note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info)
Steps to Reproduce
- Upgrade to Rust 1.83
- maturin develop
Your operating system
Linux
Your Python version (python --version)
3.12
Your Robyn version
main branch
Additional Info
No response
We need to update pyo3 , i.e. support python3.13