matrix-docker-ansible-deploy icon indicating copy to clipboard operation
matrix-docker-ansible-deploy copied to clipboard
verified publisher icon spantaleev

multiple fed sender worker result in the same worker_name

Open MTRNord opened this issue 5 years ago • 2 comments

Due to the fact that the name is using the port to count up it results in fed sender workers having the same worker_name as it is always port 0. This probably should use the instance id instead

MTRNord avatar Mar 14 '21 01:03 MTRNord

Where is that?

Also, we currently don't support more than 1 federation sender worker (if matrix_synapse_workers_federation_sender_workers_count is more than 1, roles/matrix-synapse/tasks/validate_config.yml will yell at you).

Of course, it would be great to support more, but that means fixing a few more things as well. I'm not sure which one you're pointing at though.

spantaleev avatar Mar 15 '21 06:03 spantaleev

This is something I realised while implementing federation_sender_instances in a local fork. Though it didnt yell at me before with more than 1 of them 🤔 I will try to mke a PR sthis week.

MTRNord avatar Mar 15 '21 09:03 MTRNord