matrix-docker-ansible-deploy icon indicating copy to clipboard operation
matrix-docker-ansible-deploy copied to clipboard

Added official S3 Storage Module for Synapse

Open BackInBash opened this issue 2 years ago • 4 comments

Hey 🖖,

this is a Pull to implement the S3 storage backend as described in #176.

In order for the Plugin to work I modified the build process of the synapse container and injected the module installation. As of now its doing its thing, but uploads both to the local and the remote store. In any possible configuration.

https://github.com/BackInBash/matrix-docker-ansible-deploy/blob/542e8ec119cb7d093ddeafb02ccdbbc980fe32ab/roles/matrix-synapse/defaults/main.yml#L583-L588

BackInBash avatar Apr 19 '22 18:04 BackInBash

Thanks for the review. I'll looking into it ;)

BackInBash avatar Apr 20 '22 07:04 BackInBash

Thanks for working on improving this! Let me know when it's ready for review.

spantaleev avatar Apr 21 '22 08:04 spantaleev

what's missing here?

xangelix avatar Jul 04 '22 19:07 xangelix

Config Nesting from setup_install.yml into homeserver.yaml.j2 is not working as intended. Example: https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1769/files/6d305e432cae8e6d68463bcb3e13ab620e2a2aee#diff-3f01d105d3b729eb1a3cedbdc4ec41036d66dab6c4983e5464e2709a3d9ae637

Implementation: https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1769/files/589a821f1b83bb1221425e6192e7bd71a5d37b13..33bd2f3faba7d838583aa14eea8fcf0670b9995c#diff-b0da8a56987a4474d3b70fb97aa67db6ed7874b0a94e62575e17e32045c02892

BackInBash avatar Jul 04 '22 22:07 BackInBash

@spantaleev able to close after https://github.com/spantaleev/matrix-docker-ansible-deploy/commit/ac7cb3619dfe522af280875566e859007f7a0374

xangelix avatar Oct 16 '22 23:10 xangelix