Andrea Longhi
Andrea Longhi
@kennyadsl regarding your question about routes, what you wrote is certainly true, but I think I am missing something as I don't see why this can be a problem. Can...
I think I understand your concerns. Looking at a concrete example, `spree_auth_devise` file `lib/frontend/spree/users/show.html.erb` overwrites the new file `frontend/app/views/spree/users/show.html.erb`. One way to look at this, is to consider the new...
@kennyadsl 👍 on deprecations/warnings when an old version of `solidus_auth_devise` is found.
I've been experimenting a bit with this PR, and I think it is safe to merge anytime, as the code in `solidus_auth_devise` will always take precedence over the one defined...
@kennyadsl I didn't find any issue with that when I tested the feature. The last routing file loaded will simply override the previous route, if they're the same.
@kennyadsl the way the PR sits now it won't, as that PR doesn't change the admin routes. I bet is it will still call `edit_admin_account_url` which is not what we...
@kennyadsl I didn't want to use a term that strongly conveys the meaning of absolutely destroying/removing shipments, because this doesn't happen always (i.e. when order is completed it doesn't) and...
@waiting-for-dev looks good to me, I'm going to change the name according to your suggestion 👍
Definitely not intentional (I introduced KT-Paperclip on v2.11), I agree we should have the same high version constraint that we have in 3.x
I'm seeing deadlocks caused by this method as well. I don't have the full context, but I believe there are parallel processes that end up calling this method and when...