hepmc3: add v3.3.1

[paulgessinger]

Adds version 3.3.1 of HepMC3.

[spackbot-app[bot]]

@luketpickering can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

• hepmc3

[paulgessinger]

@wdconinc added CMake constraint now. Can I do it like this with depends_on or do I need to introduce separate conflicts?

[wdconinc]

@wdconinc added CMake constraint now. Can I do it like this with depends_on or do I need to introduce separate conflicts?

Yes, perfectly fine. You didn't even need to modify the older depends_on, and could have used:

    depends_on("[email protected]:", type="build")
    depends_on("[email protected]:", when="@3.3.1:", type="build")

since the second one will just override the first one for newer versions.

[wdconinc]

There's an issue with ci that's under investigation. Might be Monday before we can merge this.

[paulgessinger]

@wdconinc CI failure seems unrelated

[wdconinc]

The CI error seems to be due to whizard compiling with -std=c++11 even though it (through hepmc3?) depends on root compiled with C++20. @vvolkl You're a whizard user, right?

[wdconinc]

Whizard issue hopefully resolved by https://github.com/spack/spack/pull/50255.

[paulgessinger]

The failure looks like ROOT's classic C++17 polyfill inconsistency, where ROOT itself is built with C++17 but a depending project is not.

I'm struggling to see how this can be related.

[haampie]

Hi @paulgessinger, this package-related pull request can be migrated from spack/spack to spack/spack-packages using the migrate-pkg-prs utility.

We encourage authors to run the migration script themselves to preserve author attribution.

You can migrate all your open pull requests at once, following the steps in the documentation.

---

This comment was posted automatically.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity.

If the pull request is waiting for a reply from reviewers, feel free to ping them as a reminder. If it is waiting and has no assigned reviewer, feel free to ping @spack/spack-releasers or simply leave a comment saying this should not be marked stale. This will reset the pull request's stale state.

To get more eyes on your pull request, you can post a link in the #pull-requests channel of the Spack Slack. Thank you for your contributions!