spack icon indicating copy to clipboard operation
spack copied to clipboard

re2c: add versions

Open jrood-nrel opened this issue 10 months ago • 4 comments

jrood-nrel avatar Apr 30 '24 18:04 jrood-nrel

Hi @jrood-nrel! I noticed that the following package(s) don't yet have maintainers:

  • re2c

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("jrood-nrel")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame re2c

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

spackbot-app[bot] avatar Apr 30 '24 18:04 spackbot-app[bot]

@johnwparent Are you interested in reviewing this PR as someone who made significant changes to the package within the last year?

tldahlgren avatar Apr 30 '24 18:04 tldahlgren

@johnwparent Are you interested in reviewing this PR as someone who made significant changes to the package within the last year?

Yes, thanks, re2c is critical for Windows in order to bootstrap clingo without issue (since we have no cached clingo ATM) so it'll be good to review this, thanks for the ping!

johnwparent avatar Apr 30 '24 18:04 johnwparent

Gitlab failure is legit:

==> Error: ProcessError: Command exited with status 1:
    './configure' '--prefix=/home/software/spack/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeh/morepadding/linux-ubuntu18.04-x86_64_v3/gcc-7.5.0/re2c-3.1-sawnuiochwi5a6sthukqnjzk5vwq6grb' '--disable-benchmarks' '--disable-debug' '--disable-dependency-tracking' '--disable-docs' '--disable-lexers' '--disable-libs' '--enable-golang'
1 error found in build log:
     6     checking for gawk... no
     7     checking for mawk... mawk
     8     checking whether make sets $(MAKE)... yes
     9     checking whether make supports nested variables... yes
     10    checking whether make supports nested variables... (cached) yes
     11    checking for a Python interpreter with version >= 3.7... none
  >> 12    configure: error: no suitable Python interpreter found

Looks like the new versions require some additional logic re: python.

Once the Gitlab pipeline passes I'll validate Windows by hand.

johnwparent avatar May 01 '24 19:05 johnwparent

Any comment on this https://github.com/spack/spack/pull/43924#pullrequestreview-2064633135 @jrood-nrel ?

alalazo avatar Jun 05 '24 15:06 alalazo

@spackbot run pipeline

alalazo avatar Jun 06 '24 06:06 alalazo

I've started that pipeline for you!

spackbot-app[bot] avatar Jun 06 '24 06:06 spackbot-app[bot]

@spackbot run pipeline

alalazo avatar Jun 07 '24 05:06 alalazo

I've started that pipeline for you!

spackbot-app[bot] avatar Jun 07 '24 05:06 spackbot-app[bot]

@jrood-nrel We need further constraints to bootstrap clingo on old python versions. I can look into that next week, if you don't have bandwidth.

alalazo avatar Jun 07 '24 17:06 alalazo