spack
spack copied to clipboard
spack
update to faiss1.7.2
(1) updated faiss to version 1.7.2. (2) the new build system is cmake. followed the example from here to deprecate old messages. (3) added new variants for building shared libs
@adamjstewart @alalazo i need some help with this. the cmake creates multiple test targets, e.g., TestGPUDistance. the make TestGPUDistance command build as well as runs the test. Using spack, however, I am not able to link to to cudart.so. I am not able fix this error. Could you please look at the package to see if there are any obvious issues? I am able to load the python package successfully, so that i think works.
I don't know much about CMake. Have you tried asking the faiss developers?
i havent. i am able to build and run tests correctly directly through cmake. but it fails when built through spack.. so my guess is that spack is not forwarding cuda paths correctly. may be?
Converting to draft since reading the comments this one doesn't seem ready to be reviewed / merged. Feel free to ping me when the issues are fixed.
the package install and runs fine on Summit. So looks like there is nothing wrong with that.
However, there is a problem on lassen when we run with +tests. my guess is that it's something to with how modules are setup.. perhaps they are not setting the LD_LIBRARY_PATH.. not sure.
@alalazo , can you merge this one in. this works fine and the issue seems to be lassen, not the package.py
@adamjstewart @alalazo : another ping with request to review and merge this
@alalazo can we merge this in quick? there are some styling changes that you asked for, but some of those can be done along the way in future. the package works and that is what is most important. this is creating a bunch of confusion for folks who are wanting to use this.
