罗泽轩 comments

Results 400 comments of


                                            罗泽轩

A "git mv" that preserves history

It sounds good. What about your opinions? @hemanth

The description of Envoy requirement is confusing.

> -2 minor version of Kuma So the supported Envoy version is from the `kuma@minor - 2/tools/releases/version.sh#xx` to `kuma@master/tools/releases/version.sh#xx`?

Roadmap to add more features?

> I have no idea about the shared data/queue. could you help to give some points for refers? I think about it again. We don't need it because unlike the...

Unused code gets `go vet` error

> this could be a proper way to mute this vet warning, but I'm not sure if it's worthing, it may complicate the code. What about passing the Data ptr...

Unused code gets `go vet` error

Actually we can delay the `possibly passing Go type with embedded pointer to C` suppression as the headers argument is not used at all. 😃

Trying to format a gdb.Value instead of an integer

@erikcw Just provide a quick fix for the issue. Could you try it out?

loongarch64, lj_arch.h:73:2: error: #error "No support for this architecture (yet)"

loongarch64 is not supported by LuaJIT yet.

improve: checking ev->pending_eof before peeking data from tcp buffer

Look like the original `ngx_http_lua_check_broken_connection` is modified from `ngx_http_upstream_check_broken_connection` in 2012. In 2013, Nginx added the `NGX_USE_EPOLL_EVENT` check to fix https://trac.nginx.org/nginx/ticket/320. However, this code doesn't synchronize the fix.

improve: checking ev->pending_eof before peeking data from tcp buffer

@tokers `ngx_http_lua_check_broken_connection` doesn't have this patch because it is written in 2012, while this patch is added to `ngx_http_lua_check_broken_connection` in 2013.

Support wasm in openresty?

You can take a look at this project: https://github.com/api7/wasm-nginx-module