starfish icon indicating copy to clipboard operation
starfish copied to clipboard

registration in starfish, Part 1: zero out wrapped values

Open berl opened this issue 6 years ago • 6 comments

The lone registration module fourier_shift uses scipy's ndimage.fourier.fourier_shift, which wraps intensity values from one side of the image to the other. I've tried to fix this by tacking on some code to zero out those wrapped values in berl-zero-wrapped-intensities.

berl avatar Aug 14 '18 08:08 berl

I've also fixed this (not inn a branch yet) by cropping the images. Is zeroing out the values preferred to cropping? Should we support both options?

dganguli avatar Aug 14 '18 16:08 dganguli

@dganguli isn't the cropping risky once you get into multi FOV data? it changes the shape of the FOV which would/should propagate all the way up to the image stack. E.g. you do the crop, use the result to localize a spot and then want to go back to the unprocessed data and check the raw intensity values in a neighborhood around the spot. This would be trivial with the zero'd result (or in the IntensityTable with #410 ) and annoying with a cropped result.

berl avatar Aug 14 '18 16:08 berl

that sir, is an extremely good point.

dganguli avatar Aug 14 '18 16:08 dganguli

++ zeroing out.

ttung avatar Aug 20 '18 17:08 ttung

@shanaxel42 isn't this done?

ttung avatar Jun 06 '19 20:06 ttung

By this are you referring to padding? Because that is not done

shanaxel42 avatar Jun 13 '19 22:06 shanaxel42