webbpsf icon indicating copy to clipboard operation
webbpsf copied to clipboard

Add detector effects as default in the oversampled extension

Open obi-wan76 opened this issue 1 year ago • 6 comments

Currently, detector effects are included by default in the detector sampled extension. Detector effects in the oversample PSF can be include via the grid PSF function only. We should add detector effects (IPC/charge diffusion) to both extension by default. Note that IPC effects happens in the detector pixels, thus, physically it make sense just to have them included in the detector sample PSF, as currently implemented. However, people are increasingly interested in more realistic oversampled simulations as a way to compare with semi-empirical oversample PSF from observations.

obi-wan76 avatar Sep 05 '23 14:09 obi-wan76

Yes please, this would be really important for us. Thank you

amn3142 avatar Sep 18 '23 22:09 amn3142

See #768

obi-wan76 avatar Dec 07 '23 14:12 obi-wan76

Just confirming that if we install the latest develop version it will include this?

amn3142 avatar Dec 07 '23 19:12 amn3142

Once the PR is merge, it is currently under revision.

obi-wan76 avatar Dec 08 '23 19:12 obi-wan76

If you remember, could you let me know when this gets merged?

amn3142 avatar Dec 24 '23 11:12 amn3142

Hi @obi-wan76 I was wondering if this was merged? Thanks

amn3142 avatar Feb 08 '24 20:02 amn3142

@amn3142 This has been merge into dev. #768

obi-wan76 avatar Apr 24 '24 12:04 obi-wan76

@obi-wan76 is there a new webbpsf_data file I need to download to use this feature?

amn3142 avatar May 13 '24 17:05 amn3142

@amn3142 No, you just need to download and install the latest dev branch of WebbPSF. Once you do your simulations you can always check the information inside the fits file header (or the HDUList) to find the parameters for the detector effects. Thanks!

obi-wan76 avatar May 13 '24 19:05 obi-wan76