webbpsf icon indicating copy to clipboard operation
webbpsf copied to clipboard

Add some more per-instrument specializations in setup_sim_to_match_file

Open marcio-melendez opened this issue 2 years ago • 3 comments

First reported by Martha Boyer: "It appears to just grab the FILTER keyword from the image header and assign that to inst.filter, but that won’t work for images where the filter is in the pupil wheel (e.g., pupil+filter = F164N+F150W2). In this example, Webbpsf is assigning inst.filter=F150W2, but it should assign inst.filter to F164N."

Further confirm with some of the wavefront sensing observations (WL images) where the combination F212N (filter) and WLM8 (pupil) simulates the F212N filter, not the WL image

marcio-melendez avatar Aug 21 '23 22:08 marcio-melendez

from Martha "webbpsf.setup_sim_to_match_file, but it’s not working because the image headers have PUPIL = MASKBAR & webbpsf says that NIRCam doesn’t have a pupil mask called MASKBAR. Presumbly webbpsf uses MASKSWB and MASKLWB, but that’s not what’s in the image header"

marcio-melendez avatar Oct 06 '23 20:10 marcio-melendez

See #768

marcio-melendez avatar Dec 07 '23 14:12 marcio-melendez

This issue shouldn't have been closed in December, since the PR #768 wasn't (and still isn't) merged.

mperrin avatar Mar 22 '24 14:03 mperrin

PR #768 was merged in April, so this can be considered closed now.

mperrin avatar May 15 '24 18:05 mperrin