webbpsf
webbpsf copied to clipboard
spacetelescope
Hardcoded pupil dimensions within JWST SI WFE models
When I tried swapping in OSIM pupils and OPD maps, it became clear there's code expecting a 1024x1024 array (lots of IndexError: index 924 is out of bounds for axis 0 with size 162).
Minor, for people using the provided OPD and pupil maps. But worth thinking about how the models could be refactored to compute things on the right sampling "just in time" (using Wavefront.coordinates, probably).
I'm not surprised. I put some thought into this when coding these but never fully tested this. At least some of the code should be using the input array sizes (see https://github.com/mperrin/webbpsf/blob/master/webbpsf/optics.py#L1064) but I'm not surprised that some other places slipped through the cracks.
Can you paste an error log or at least which line that's coming from? The MIRIFieldDependentAberrationAndObscuration class definitely has hard coded 1024s, and the main WebbFieldDependentAberration class only if the include_oversize option is set to True, which isn't the default.
Yeah, it's the MIRI one. The constructor for that WFE element has include_oversize set to True by default, as well. Good to know it's not everywhere :)
For the cross checks you're doing now, it would be a reasonable workaround to make a branch of the code that just invokes the regular WebbFieldDependentAberration instead of the special MIRI one. Trying to draw in the field dependent obscuration is irrelevant if you're patching in OSIM pupil maps anyway. So try just commenting out line 722 in webbpsf_core.py that invokes the MIRI aberration class.
Is the obscuration really not relevant for OSIM? Or are you saying if the obscuration were in the beam at that field point, Randal's pupil shapes would already include it?
Side note, no source edits needed (god bless Python):
miri._si_wfe_class = webbpsf.optics.WebbFieldDependentAberration