notebooks icon indicating copy to clipboard operation
notebooks copied to clipboard

[WIP] Updating the input for tweakreg

Open catherine-martlin opened this issue 5 years ago • 5 comments

Changed list input for tweakreg to be hardcoded list instead of using glob as different systems can end up with files in different orders.

catherine-martlin avatar Mar 26 '19 15:03 catherine-martlin

Might need a squash so that the uncleared notebook doesn't make it into master history.

pllim avatar Mar 26 '19 15:03 pllim

@catherine-martlin , try rebase to use the longer timeout limit that Josh implemented earlier.

pllim avatar Mar 26 '19 18:03 pllim

Something isn't right with the commit history...

Try this:

git fetch upstream master
git rebase upstream/master

pllim avatar Apr 08 '19 17:04 pllim

@pllim - Thank you! Definitely still figuring out how to properly rebase all the different ways when working on my fork and branch. Do you think that cleared it up appropriately?

Edit: The checks just finished though, and it looks like one of the TESS notebooks failed this time - could I have missed some needed updates when I just rebased with upstream/master?

catherine-martlin avatar Apr 08 '19 18:04 catherine-martlin

@catherine-martlin , the history still doesn't look quite right. Ideally, you should only see your own relevant commits as part of this PR in the commit history.

pllim avatar Apr 08 '19 19:04 pllim