jwst icon indicating copy to clipboard operation
jwst copied to clipboard

The maskpt parameter in outlier detection is not useful for TSO data

Open emolter opened this issue 1 year ago • 0 comments

For outlier detection in TSO mode, the weight array is always just a DQ mask, so its values are either 0 or 1. It is then passed into a function that compares the weights with a threshold set by the maskpt parameter here. But this is confusing, and renders the maskpt essentially pointless for any reasonable value, because all the weights are either 0 or 1. That parameter should be removed as an input to the TSO mode, and the call to compute_weight_threshold should be replaced with something that more clearly indicates what actually happens.

edit: the same appears to be true for coronagraphic data

emolter avatar Oct 11 '24 16:10 emolter