jwst icon indicating copy to clipboard operation
jwst copied to clipboard

JP-3543: Allow alternate resampling weight type in outlier detection

Open melanieclarke opened this issue 1 year ago • 3 comments

Resolves JP-3543

Closes #8289

This PR passes the input weight_type parameter to all the resampling functions called within the outlier_detection step.

Checklist for maintainers

  • [ ] added entry in CHANGES.rst within the relevant release section
  • [ ] updated or added relevant tests
  • [ ] updated relevant documentation
  • [ ] added relevant milestone
  • [ ] added relevant label(s)
  • [ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
  • [ ] Make sure the JIRA ticket is resolved properly

melanieclarke avatar Feb 20 '24 14:02 melanieclarke

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.79%. Comparing base (2fb073e) to head (2441389). Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8290      +/-   ##
==========================================
+ Coverage   75.31%   75.79%   +0.48%     
==========================================
  Files         474      476       +2     
  Lines       38965    39428     +463     
==========================================
+ Hits        29345    29884     +539     
+ Misses       9620     9544      -76     
Flag Coverage Δ *Carryforward flag
nightly 77.67% <ø> (+0.33%) :arrow_up: Carriedforward from 9f22816

*This pull request uses carry forward flags. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 15:02 codecov[bot]

Regtests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1220/

tapastro avatar Feb 21 '24 15:02 tapastro

I think the regression test failures are unrelated. The MIRI tests pass locally on this branch with current truth files. The failed NIRCam test is also failing on main.

melanieclarke avatar Feb 28 '24 20:02 melanieclarke

Started another regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1394

Results are clean. Looks good.

hbushouse avatar Apr 11 '24 19:04 hbushouse