jwst icon indicating copy to clipboard operation
jwst copied to clipboard

JP-3533 Update emicorr to run on FAST mode MIRI data

Open penaguerrero opened this issue 1 year ago • 4 comments

Resolves JP-3533

Closes #8264

This PR addresses the behavior of the emicorr step. Previously it would run always for all MIRI data. The MIRI team requested it is skipped when no reference file is found and to add a parameter to allow the user to run the step for given frequencies with an on-the-fly generated reference file.

Checklist for maintainers

  • [x] added entry in CHANGES.rst within the relevant release section
  • [x] updated or added relevant tests
  • [x] updated relevant documentation
  • [x] added relevant milestone
  • [x] added relevant label(s)
  • [ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
  • [ ] Make sure the JIRA ticket is resolved properly

penaguerrero avatar Feb 09 '24 16:02 penaguerrero

Codecov Report

Attention: Patch coverage is 56.92308% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 75.27%. Comparing base (2fb073e) to head (41afdb6). Report is 1 commits behind head on master.

Files Patch % Lines
jwst/emicorr/emicorr_step.py 0.00% 18 Missing :warning:
jwst/emicorr/emicorr.py 78.72% 10 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8270      +/-   ##
==========================================
- Coverage   75.31%   75.27%   -0.04%     
==========================================
  Files         474      474              
  Lines       38965    38971       +6     
==========================================
- Hits        29345    29335      -10     
- Misses       9620     9636      +16     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (ø) Carriedforward from 9e17fd4

*This pull request uses carry forward flags. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 09 '24 17:02 codecov[bot]

@penaguerrero Is this still WIP or is it ready for review?

hbushouse avatar Feb 13 '24 15:02 hbushouse

From my side it is ready but I was waiting to hear confirmation from Misty that it is indeed what they want.

penaguerrero avatar Feb 13 '24 15:02 penaguerrero

Regression test run?

hbushouse avatar Feb 27 '24 17:02 hbushouse

regression test: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1308/

penaguerrero avatar Mar 13 '24 14:03 penaguerrero