jwst icon indicating copy to clipboard operation
jwst copied to clipboard

JP-3513: Remove warning about inaccurate errors

Open penaguerrero opened this issue 1 year ago • 4 comments

Resolves JP-3513

Closes #

This PR addresses removal of unnecessary warning when weight_type is set to 'exptime': "Use of EXPTIME weighting will result in incorrect propagated errors in the resampled product". Errors are propagated identically for the 'exptime' and 'ivm' weight options.

The message is benign, but it has been asked about in helpdesk questions, and might unnecessarily deter users from using 'exptime' weights in place of 'ivm'.

Checklist for maintainers

  • [ ] added entry in CHANGES.rst within the relevant release section
  • [ ] updated or added relevant tests
  • [ ] updated relevant documentation
  • [ ] added relevant milestone
  • [ ] added relevant label(s)
  • [ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
  • [ ] Make sure the JIRA ticket is resolved properly

penaguerrero avatar Feb 02 '24 15:02 penaguerrero

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.65%. Comparing base (4179c09) to head (969cfd9). Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8258       +/-   ##
===========================================
+ Coverage   57.97%   75.65%   +17.67%     
===========================================
  Files         387      477       +90     
  Lines       38830    39651      +821     
===========================================
+ Hits        22513    29998     +7485     
+ Misses      16317     9653     -6664     
Flag Coverage Δ *Carryforward flag
nightly 77.66% <ø> (?) Carriedforward from 7d15aaf

*This pull request uses carry forward flags. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 02 '24 16:02 codecov[bot]

This should not be merged until there's consensus as to whether the warning message is accurate (i.e. I don't think it's benign, as has been suggested).

hbushouse avatar May 06 '24 17:05 hbushouse

@hbushouse @drlaw1558 - can this one be merged, now that error propagation for exptime and ivm weights are handled self-consistently (#8437)?

melanieclarke avatar May 17 '24 21:05 melanieclarke

@melanieclarke Seems reasonable to me as the entire point of all of that work was to fix the error propagation! @hbushouse 's call though.

drlaw1558 avatar May 18 '24 14:05 drlaw1558

One more thing would make this PR perfect: set default weight to exptime, especially given that #7563 still hasn't been approved.

That's going to be done via the use of parameter reference files for the resample/resample_spec steps, where each instrument/mode will choose to set the default to 'exptime' if they want. There are still one or more modes where 'ivm' seems to be preferred.

hbushouse avatar Jun 06 '24 12:06 hbushouse