jwst
jwst copied to clipboard
JP-2669: Updating tests due to new STCAL behavior for NaNs in rateints product.
…es and their corresponding DQ flags. The rateints product will have all NaNs set to zero with the corresponding DQ flag set to DO_NOT_USE.
Resolves JP-2669
This PR addresses testing changes needed due to updates in STCAL PR 112, which updates the way the rateints gets computed. NaNs in the rateints products are converted to 0. and the corresponding DQ value has the DO_NOT_USE
flag set.
Checklist
- [x] added entry in
CHANGES.rst
within the relevant release section - [x] updated or added relevant tests
- [ ] updated relevant documentation
- [x] added relevant milestone
- [x] added relevant label(s)
I assume that we need to wait to merge this until https://github.com/spacetelescope/stcal/pull/112 gets merged, right?
I assume that we need to wait to merge this until spacetelescope/stcal#112 gets merged, right?
Yes. Also I was told there has been some discussion on what to do with NaNs, so not sure how quickly we should merge either the STCAL and JWST PR's right now till we here back about this.
@kmacdonald-stsci can you rebase this to include the updates to setup that pin the version of jsonschema? All the CI's are failing because of that issue.
Codecov Report
Merging #6949 (595e148) into master (6dc2615) will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #6949 +/- ##
==========================================
- Coverage 79.27% 79.24% -0.03%
==========================================
Files 414 414
Lines 37478 37478
==========================================
- Hits 29709 29701 -8
- Misses 7769 7777 +8
Flag | Coverage Δ | *Carryforward flag | |
---|---|---|---|
nightly | 79.23% <ø> (ø) |
Carriedforward from 6dc2615 | |
unit | 53.08% <ø> (-0.03%) |
:arrow_down: |
*This pull request uses carry forward flags. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
jwst/transforms/integration.py | 76.47% <0.00%> (-5.89%) |
:arrow_down: |
jwst/datamodels/container.py | 81.95% <0.00%> (-2.64%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.