jwst
jwst copied to clipboard
JP-2375: NIRISS V3 of CONF files
Closes #6558 Resolves JP-2375
Checklist
- [x] Tests
- [ ] Documentation
- [x] Change log
- [x] Milestone
- [x] Label(s)
Codecov Report
Base: 79.68% // Head: 79.72% // Increases project coverage by +0.04%
:tada:
Coverage data is based on head (
545a66c
) compared to base (d1eda60
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #6803 +/- ##
==========================================
+ Coverage 79.68% 79.72% +0.04%
==========================================
Files 411 411
Lines 37231 37271 +40
==========================================
+ Hits 29667 29715 +48
+ Misses 7564 7556 -8
Flag | Coverage Δ | *Carryforward flag | |
---|---|---|---|
nightly | 79.64% <100.00%> (ø) |
Carriedforward from d1eda60 | |
unit | 53.23% <100.00%> (-0.01%) |
:arrow_down: |
*This pull request uses carry forward flags. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
jwst/assign_wcs/niriss.py | 75.00% <ø> (+4.54%) |
:arrow_up: |
jwst/assign_wcs/util.py | 83.78% <100.00%> (ø) |
|
jwst/extract_2d/grisms.py | 92.88% <100.00%> (+0.94%) |
:arrow_up: |
jwst/transforms/models.py | 94.21% <100.00%> (+0.10%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I've tested this with in-flight NIRISS grism observations and a patched wfss_contam
step. It all seems to be working properly. So I would be OK with merging this once my review questions have been answered.
I addressed the comments and enabled previously xfailed tests. Swara tested with this PR and hit the error in the contamination step.
Whoops - you've got 1 little flake8 issue.
Did a full regression test ever get run against this PR branch? A couple of us tested it on NIRISS WFSS processing only, which seemed to run OK, but never a full regtest.