jwst icon indicating copy to clipboard operation
jwst copied to clipboard

Add niriss soss datamodel

Open sosey opened this issue 3 years ago • 3 comments

Closes #

Resolves JP-

Description

This PR comes from a discussion with @eslavich about reference file validation and adds a datamodel for the niriss SOSS wavelength tables, the specwcs reference file...it likely still needs work, tests, a doc update and should be reviewed by @nden or someone familiar with niriss soss mode before acceptance. There's an example new reference file as well on CS.

Checklist

  • [ ] Tests
  • [ ] Documentation
  • [ ] Change log
  • [x] Milestone
  • [x] Label(s)

sosey avatar Sep 13 '21 12:09 sosey

Codecov Report

Merging #6338 (fd457c0) into master (aafc5c8) will increase coverage by 0.03%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6338      +/-   ##
==========================================
+ Coverage   79.03%   79.06%   +0.03%     
==========================================
  Files         401      401              
  Lines       34335    34558     +223     
==========================================
+ Hits        27137    27324     +187     
- Misses       7198     7234      +36     
Flag Coverage Δ *Carryforward flag
nightly 79.04% <71.42%> (ø) Carriedforward from 7196ca4
unit 56.94% <54.76%> (+0.01%) :arrow_up:

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/datamodels/__init__.py 100.00% <ø> (ø)
jwst/assign_wcs/niriss.py 70.99% <52.94%> (-7.72%) :arrow_down:
jwst/datamodels/wcs_ref_models.py 81.73% <84.61%> (+4.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aafc5c8...fd457c0. Read the comment docs.

codecov[bot] avatar Sep 13 '21 13:09 codecov[bot]