jwst icon indicating copy to clipboard operation
jwst copied to clipboard

outlier_detection blotting needs to properly scale based on input and output pixel scales

Open stscijgbot opened this issue 5 years ago • 1 comments

Issue JP-794 was created by James Davies:

With

https://github.com/spacetelescope/jwst/pull/3651

The scaling between the median image and the blotted image is set to 1, which is the default. But ideally it should scale based on the pixel scale (CDELTn) of the input and output image, in case a user specifies a smaller pixel scale for median.

Spectral data no longer have CDELTn keywords, so a general function of computing the pixel scale for imaging and spectral data needs to be written and used here.

There are a couple other places in the pipeline where a pixel scale is computed, so perhaps some of that code can be generalized and used here.  Ideally, we should have one function that computes this in a consistent way for all our data.

Possibly it could be a method on the GWCS object too?

stscijgbot avatar Jun 14 '19 17:06 stscijgbot

Comment by Karl Gordon: Is this something that is straightforward to implement/test?  If so, then I can look at doing this in the PR I'm working on for this step.

stscijgbot avatar Mar 09 '21 20:03 stscijgbot

Original JP ticket has been withdrawn.

hbushouse avatar Jan 09 '24 16:01 hbushouse