jwql icon indicating copy to clipboard operation
jwql copied to clipboard

[WIP]: Fix EDB download button

Open bhilbert4 opened this issue 2 years ago • 5 comments

This PR fixes the Download Data button on the EDB page. I've also updated the name of the file to include the mnemonic name and start/end dates, rather than being generic.

bhilbert4 avatar Jul 06 '22 14:07 bhilbert4

Hello @bhilbert4, Thank you for updating !

Line 52:34: E126 continuation line over-indented for hanging indent Line 74:1: E402 module level import not at top of file Line 75:1: E402 module level import not at top of file Line 214:64: E226 missing whitespace around arithmetic operator Line 974:17: W503 line break before binary operator Line 975:17: W503 line break before binary operator Line 976:17: W503 line break before binary operator Line 977:17: W503 line break before binary operator Line 1327:9: E722 do not use bare 'except'

Comment last updated at 2022-07-06 15:16:33 UTC

pep8speaks avatar Jul 06 '22 14:07 pep8speaks

This now allows me to download EDB search results. Looking at the changes though, I'm not sure why it wasn't working before. All I really did was change the variable name and updated the name of the file to save into.

bhilbert4 avatar Jul 06 '22 15:07 bhilbert4

I should say that this worked for me locally. Probably still a good idea to test on one of the servers.

bhilbert4 avatar Jul 06 '22 15:07 bhilbert4

Switching back to the develop branch and re-testing (locally), I'm now able to download the file. Very confusing. But I've confirmed that the develop branch on the servers fails to download the file.

bhilbert4 avatar Jul 06 '22 15:07 bhilbert4

Testing on the test server: The csv file is being saved in the expected location. So the issue must be that when the download button is pressed, it's looking in the wrong place for the file?

bhilbert4 avatar Jul 07 '22 18:07 bhilbert4