jwql icon indicating copy to clipboard operation
jwql copied to clipboard

[WIP] nirspec TA monitors: wata and msata

Open penaguerrero opened this issue 3 years ago • 4 comments

These are the initial TA monitors for NIRSpec WATA and MSATA

penaguerrero avatar Feb 21 '22 20:02 penaguerrero

Hello @penaguerrero, Thank you for updating !

Line 767:90: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Line 508:90: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Line 1093:17: W503 line break before binary operator Line 1094:17: W503 line break before binary operator Line 1095:17: W503 line break before binary operator Line 1096:17: W503 line break before binary operator

Comment last updated at 2022-09-09 17:29:20 UTC

pep8speaks avatar Feb 21 '22 20:02 pep8speaks

Thanks @penaguerrero! I will review this PR sometime this week, and also set everything up on the dev/test/ops servers to get it running there.

bourque avatar Feb 28 '22 20:02 bourque

@penaguerrero I went ahead and checked/approved the changes, have you by chance made the changes to the web application to make the figures we generate here visible? Because as of right now, I don't see it linked under monitors.

Screen Shot 2022-05-13 at 10 14 58 AM

mfixstsci avatar May 13 '22 14:05 mfixstsci

Still reviewing, need to address pep8 issues.

mfixstsci avatar Aug 22 '22 20:08 mfixstsci