jwql
jwql copied to clipboard
[WIP]: Add EDB telemetry monitor
This PR adds the refactored engineering database telemetry monitor.
Starting with the code as originally written, and using the documentation for the MIRI monitor as a guide, we plan to adapt the EDB telemetry monitor to make it useful for all instruments.
Still early days here. Lots of modifications still to make.
Resolves #814 Resolves #351 Resolves #341
Hello @bhilbert4, Thank you for updating !
- In the file
jwql/edb/engineering_database.py
:
Line 452:21: E117 over-indented Line 454:21: E117 over-indented Line 1316:9: E265 block comment should start with '# ' Line 1317:9: E265 block comment should start with '# '
Line 428:13: E303 too many blank lines (2) Line 551:21: E265 block comment should start with '# ' Line 573:57: E262 inline comment should start with '# ' Line 578:21: E265 block comment should start with '# ' Line 855:92: W504 line break after binary operator Line 856:5: E129 visually indented line with same indent as next logical line Line 861:110: W504 line break after binary operator Line 1102:13: E265 block comment should start with '# ' Line 1301:9: E265 block comment should start with '# ' Line 1302:9: E265 block comment should start with '# ' Line 1373:21: E265 block comment should start with '# ' Line 1380:25: E265 block comment should start with '# ' Line 1460:25: E303 too many blank lines (2) Line 1466:25: E303 too many blank lines (2) Line 1471:25: E303 too many blank lines (2) Line 1492:25: E303 too many blank lines (3) Line 1501:17: E303 too many blank lines (2) Line 1504:17: E722 do not use bare 'except' Line 1508:17: E303 too many blank lines (2) Line 1617:13: E303 too many blank lines (2) Line 1621:13: E303 too many blank lines (3) Line 1782:5: E303 too many blank lines (2) Line 1796:9: E303 too many blank lines (2) Line 1939:73: E231 missing whitespace after ',' Line 1968:24: E225 missing whitespace around operator Line 1988:28: E225 missing whitespace around operator
Line 12:1: E265 block comment should start with '# ' Line 13:1: E265 block comment should start with '# ' Line 17:22: E226 missing whitespace around arithmetic operator Line 18:21: E226 missing whitespace around arithmetic operator Line 24:19: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 82:27: E226 missing whitespace around arithmetic operator Line 198:13: E265 block comment should start with '# ' Line 203:13: E265 block comment should start with '# '
- In the file
jwql/tests/test_edb_telemetry_monitor.py
:
Line 151:1: E305 expected 2 blank lines after class or function definition, found 1 Line 188:1: E302 expected 2 blank lines, found 1
- In the file
jwql/website/apps/jwql/data_containers.py
:
Line 52:34: E126 continuation line over-indented for hanging indent Line 74:1: E402 module level import not at top of file Line 75:1: E402 module level import not at top of file Line 214:64: E226 missing whitespace around arithmetic operator Line 974:17: W503 line break before binary operator Line 975:17: W503 line break before binary operator Line 976:17: W503 line break before binary operator Line 977:17: W503 line break before binary operator Line 1327:9: E722 do not use bare 'except'
Comment last updated at 2022-09-02 18:34:07 UTC
Getting there....

Perhaps a useful example for displaying a saved plot in the EDB monitor web page: https://stackoverflow.com/questions/55628401/unable-to-embed-json-bokeh-plot-in-django-template
For future reference: more helpful instructions on embedding a Bokeh-created json file: https://discourse.bokeh.org/t/django-embed-bokeh-graph-using-json-item/4249
- [ ] Make sure block indexes are correct when multiplying EdbMnemonic instances
- [x] Requested NIRISS mnemonics to monitor, as collected by @rcooper295 . Add a json file for these.
-
SA_ZFGGSPOSX -> FGS Guide Star position in X
-
SA_ZFGGSPOSY -> FGS Guide Star position in Y
-
SA_ZFGINSTCT -> FGS Guide Star Instrument Count. It would be great if this time-series could be binned to 20-second cadence, and plotted in relative flux units. That is, divide the flux values by the median count value, substract 1, and then multiply by 1e6 to get relative flux in parts-per-million.
-
SA_ZHGAUPST -> HGA Update Status; this defines a high-gain antenna movement, and is a two-string value (FINISHED/MOVING). This is important because HGA movements happened inevitably during TSOs, and with this we can know when this happened.
-
SA_ZMOMECIX -> Observatory momentum unit vector; could be important as a decorrelation parameter against flux measurements.
-
SA_ZMOMECIY -> Same
-
SA_ZMOMECIZ -> Same
-
SA_ZMOMMAG -> Same
-
SA_ZATTEST1 -> 1st component quaternion
-
SA_ZATTEST2 -> 2nd
-
SA_ZATTEST3 -> 3rd
-
SA_ZATTEST4 -> 4th
-
SA_ZSUNSCX -> Position of the Sun relative to spacecraft
-
SA_ZSUNSCY
-
SA_ZSUNSCZ
-
SA_ZSUNVLSCX -> Velocity of the Sun relative to spacecraft
-
SA_ZSUNVLSCY
-
SA_ZSUNVLSCZ
INIS_PWC_MOV INIS_PWC_POS NIRISS ASIC and detector temperature mnemonics – still need to find exactly what these are.
Requested NIRISS mnemonics that are not in the EDB: SA_ZSUNSCX SA_ZSUNSCY SA_ZSUNSCZ SA_ZSUNVLSCX SA_ZSUNVLSCY SA_ZSUNVLSCZ
Keep this around until #1060 is merged, and then it can be closed.