jwql
jwql copied to clipboard
spacetelescope
Fix API view for filenames per proposal and preview images
This PR fixes a small bug in the API view for retrieving a list of filenames for a given proposal.
@mfixstsci I think I've fixed these issues. I think we should remove the API view that shows all preview image filenames for an instrument (and same with the list of thumbnails per instrument). These lists are already long enough that they are creating bad gateway errors. With these views removed, a user could still build up a list of all files by looping over proposals for a given instrument and getting the preview images for each proposal.
Do you agree? Or maybe we should keep the options but comment them out for now, and hope that the bad gateway errors will be resolved independently?
All tests in data_containers are now passing, including those that are skipped on Github.
Current status: API documentation and view have been cleaned up such that they are all working and reference in-flight data. Checking the views in the browser show that everything looks good. So from that standpoint, this is ready for review. However, programmatic access is failing because the requests all return the SSO page.
Current status: API documentation and view have been cleaned up such that they are all working and reference in-flight data. Checking the views in the browser show that everything looks good. So from that standpoint, this is ready for review. However, programmatic access is failing because the requests all return the SSO page.
Thanks @bhilbert4 I am rebasing the branch now. I submitted a ticket to IT for them see if there is a way to bypass the SSO page.
@mfixstsci conflicts are resolved and the unrelated test failures have resolved themselves. I think this is ready to go.
@fix, assuming the latest test pass, are you ok with merging this? The changes to the tests that are in this PR should fix the failures seen in the filesystem monitor PR.