jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Expose bug in selecting wavelength for moment map

Open maartenbreddels opened this issue 4 years ago • 3 comments
trafficstars

Related #283

I haven't been able to solve #283, but managed to get a handle on where things go wrong and expose them in a unit test.

  • This issue is not related to the frontend, it happens all on the Python side
  • Putting a breakpoint at https://github.com/spacetelescope/jdaviz/blob/3edb474fc0046fbddc56f4355c0304d84956483f/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py#L101 I see that spec_sub.center.x is correctly 5.5e-7, and width is 1e-7,

This might be an issue with specutils, or we're holding specutils wrong.

maartenbreddels avatar Apr 06 '21 14:04 maartenbreddels

It seems https://github.com/astropy/specutils/pull/710 fixed this, because of a dev install, and not running pip install -e . again, I did not pick up the new specutils, and I guess @PatrickOgle had a similar situation.

maartenbreddels avatar Apr 06 '21 15:04 maartenbreddels

@rosteen maybe it makes sense for you to pick this up from here, because now this triggers another issue with specutils, and you see to have fixed that original issue with specutils as well.

maartenbreddels avatar Apr 06 '21 15:04 maartenbreddels

So... where was this PR going? Should we get this test in as xfail until it is fixed later?

Or if your goal was to open this to show something will fail, it did. Can we close it without merge?

pllim avatar Jun 21 '21 14:06 pllim