jdaviz
jdaviz copied to clipboard
deconfigged 3d spectral cube support
Description
This pull request improves support for 3d spectral cubes within deconfigged jdaviz.
- automatically hiding/appearing slice indicator
- imviz plugins relevance checks to ignore cube viewers/data
- subset auto-extraction
- 3D spectrum viewer creator
Change log entry
- [x] Is a change log needed? If yes, is it added to
CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add toCHANGES.rstbefore merge. If no, maintainer should add ano-changelog-entry-neededlabel.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
- [x] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the
triviallabel. - [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
- [ ] Do the proposed changes follow the STScI Style Guides?
- [ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] If new remote data is added that uses MAST, is the URI added to the
cache-download.ymlworkflow? - [ ] Did the CI pass? If not, are the failures related?
- [ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
- [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?
Codecov Report
:x: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 88.16%. Comparing base (648148a) to head (66b238b).
:warning: Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| jdaviz/core/template_mixin.py | 75.00% | 1 Missing :warning: |
| ...aviz/core/viewer_creators/spectrum3d/spectrum3d.py | 92.85% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3861 +/- ##
==========================================
+ Coverage 88.14% 88.16% +0.01%
==========================================
Files 194 195 +1
Lines 26625 26660 +35
==========================================
+ Hits 23469 23505 +36
+ Misses 3156 3155 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
If I load a 2D image and then load a cube, the cube image viewers get populated correctly, but the spectrum viewer remains empty. Trying to load the extracted 1D spectrum shows that the error is that the data is not one of [] (the list of valid data for the viewer is empty):
Probably out of scope for this PR, I can open another issue.
@cshanahan1 - can you confirm if the latest commit fixes the snackbar issue you were seeing?
EDIT: still working on the test failures that this caused.
last commit fixes the issues i saw, waiting for tests to pass before approving
reverting the workaround for the warning message since it caused other issues and we can return to it in a follow-up since this PR is now blocking other efforts