jdaviz
jdaviz copied to clipboard
for images with GWCS, show world coords on mouseover outside of bounding box using refdata
Follow up to #3483 to address comments by @pllim in https://github.com/spacetelescope/jdaviz/pull/3483#pullrequestreview-2730199866 Closes #3534
This PR enables mouseover world coordinate info in imviz on images with GWCS, even outside the bounding box, when linked by WCS. If the cursor is outside of the bounding box for the selected image layer, the coord info is taken from the reference data layer, which will be defined with FITS WCS as of #3483. No pixel coordinates are shown if the cursor is outside of the bounding box for an image with GWCS.
In the image below, the cursor is where the red "X" sits, which is on the top image layer:
When the cursor is outside the bounds of the top image layer, the world coordinates are shown in gray, without pixel info:
The same is true if you hover over the not-selected image layer...:
...unless you toggle through the layers in the coord info to Layer A, and you'll see:
Change log entry
- [ ] Is a change log needed? If yes, is it added to
CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add toCHANGES.rstbefore merge. If no, maintainer should add ano-changelog-entry-neededlabel.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
- [ ] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the
triviallabel. - [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
- [ ] Do the proposed changes follow the STScI Style Guides?
- [ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] Did the CI pass? If not, are the failures related?
- [ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
- [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?
This makes sense to me, thank you!
Minor comment (see screenshot): probably the markers plugin should not give the pixel value when outside the bounding box. The user does not know about the reference layer and seeing numbers consistent with giant pixels does not make a lot of sense. What do you think?