jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Aperture Photometry: Use photutils to calculate curve of growth and radial profile

Open stscijirahubjdat opened this issue 1 year ago • 0 comments

Issue JDAT-4966 was created on JIRA by Pey-Lian Lim:

https://photutils.readthedocs.io/en/stable/user_guide/profiles.html

Might make it easier to test and less code to maintain. Have to bump minversion of photutils to at least 1.7.

This also renders JDAT-4962 unnecessary because photutils tests them at https://github.com/astropy/photutils/tree/main/photutils/profiles/tests

Clare update: i think it might still be worth some additional coverage to make sure the plots are actually generated, and that unit conversion produces plots in the correct units, even if we are replacing with photutils; my suggestion to archive JDAT-4962 was if you added test coverage in jdaviz after replacing the code with photutils

stscijirahubjdat avatar Nov 24 '24 03:11 stscijirahubjdat