jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

fix specviz2d matched mousover marker

Open kecnry opened this issue 1 year ago • 1 comments

Description

This pull request fixes the visibility of the mouseover marker in the 1d spectrum viewer during a mouseover in the 1d spectrum viewer. This was broken by #2830 which now needs to set coords_status = True in cases in which the WCS lookup is successful.

Change log entry

  • [x] Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • [ ] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • [ ] Do the proposed changes follow the STScI Style Guides?
  • [ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • [ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • [ ] Did the CI pass? If not, are the failures related?
  • [x] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

kecnry avatar Sep 26 '24 17:09 kecnry

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.51%. Comparing base (b4fe650) to head (2d72ee0). Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   88.50%   88.51%   +0.01%     
==========================================
  Files         124      124              
  Lines       18579    18580       +1     
==========================================
+ Hits        16443    16447       +4     
+ Misses       2136     2133       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 26 '24 18:09 codecov[bot]

Works for me. Thank you for the fix!

camipacifici avatar Oct 01 '24 13:10 camipacifici