jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Backport PR #2771 on branch v3.10.x (Speed up histogram in plot options (alternative to #2763))

Open meeseeksmachine opened this issue 1 year ago • 2 comments
trafficstars

Backport PR #2771: Speed up histogram in plot options (alternative to #2763)

meeseeksmachine avatar May 08 '24 17:05 meeseeksmachine

Actually, do we want to bump glue and glue-jupyter minversions in backport? If not, maybe we don't have to backport this?

pllim avatar May 08 '24 17:05 pllim

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (bf4c599) to head (8ae01ee). Report is 53 commits behind head on v3.10.x.

Files with missing lines Patch % Lines
...nfigs/default/plugins/plot_options/plot_options.py 87.50% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           v3.10.x    #2863      +/-   ##
===========================================
+ Coverage    88.93%   88.96%   +0.02%     
===========================================
  Files          111      111              
  Lines        17165    17155      -10     
===========================================
- Hits         15266    15262       -4     
+ Misses        1899     1893       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 17:05 codecov[bot]

Actually, do we want to bump glue and glue-jupyter minversions in backport? If not, maybe we don't have to backport this?

I'm about to do a bugfix release, I'm fine deferring this personally. I can move it to 3.10.2 milestone if we want to think about it more.

rosteen avatar May 14 '24 19:05 rosteen

Let's defer. I don't see any rush. Thanks!

pllim avatar May 14 '24 19:05 pllim