jdaviz
jdaviz copied to clipboard
stretch_global switch in plot options
Description
This pull request implements support for toggling whether stretch is handled per-slice or globally across the cube (for cubeviz only).
https://github.com/spacetelescope/jdaviz/assets/877591/70f63f0d-ffc2-47fa-acbf-91e40270c988
This replaces #2621 and #2694 and would require https://github.com/glue-viz/glue/pull/2476 to be merged/pinned.
TODO:
- [x] update histogram data based on selection.
- [ ] if set to per-slice, update histogram on change to selected slice (and update screen recording)
- [ ] fix tests (histogram colorbar needs updating)
Change log entry
- [ ] Is a change log needed? If yes, is it added to
CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add toCHANGES.rstbefore merge. If no, maintainer should add ano-changelog-entry-neededlabel.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
- [x] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the
triviallabel. - [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
- [ ] Do the proposed changes follow the STScI Style Guides?
- [ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
- [ ] Did the CI pass? If not, are the failures related?
- [x] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
- [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?