jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Refactor specviz parser

Open Jdaviz-Triage-Bot opened this issue 2 years ago • 2 comments

Reporter: pllim

In general, the specviz parser is messy. Handling of spectrum list results in a lot of special logic route. I think things like these can be cleaned up:

  • get rid of casting np.array(list of Quantity) because it looks unnecessary and cause the results to lose unit that later have to be manually re-attached, which also is prone to subtle bug if there is a case where inputs have mixed units and also defeats the purpose of passing in Quantity in the first place
  • get rid of double for loop in Python; can probably be vectorized
  • see if handling of spectrum list vs single spectrum can be made more elegant in general to ease future maintenance

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.

Jdaviz-Triage-Bot avatar Sep 28 '23 16:09 Jdaviz-Triage-Bot

This issue is tracked on JIRA as JDAT-3841.

stscijgbot-jwql avatar Jul 09 '24 19:07 stscijgbot-jwql

Comment by Kyle Conroy on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #2487

stscijgbot-jwql avatar Jul 09 '24 19:07 stscijgbot-jwql