jdaviz Add keyboard shortcuts to see previous and next layer in plot options

Add keyboard shortcuts to see previous and next layer in plot options

Open javerbukh opened this issue 2 years ago • 4 comments

trafficstars

Description

This pull request is to add keyboard shortcuts 'd' and 'f' to select the previous and next viewer layer, respectively.

Change log entry

[ ] Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

[ ] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
[ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
[ ] Do the proposed changes follow the STScI Style Guides?
[ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
[ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
[ ] Did the CI pass? If not, are the failures related?
[ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
[ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

Sep 27 '23 19:09 javerbukh

I don't remember any ticket for this.

And why "d" and "f"?

Sep 27 '23 19:09 pllim

I can see how this would be convenient for long plugins like plot options, but maybe we should think about generalizing it across more/all plugins (and I worry about it being a keypress event on the viewer).