jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Notebook SPARCL+Specviz

Open camipacifici opened this issue 2 years ago • 1 comments

Description

This PR is to start a discussion with the Astro Data Lab folks on combining SPARCL and Specviz.

Change log entry

  • [ ] Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • [ ] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • [ ] Do the proposed changes follow the STScI Style Guides?
  • [ ] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • [ ] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • [ ] Did the CI pass? If not, are the failures related?
  • [ ] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

camipacifici avatar May 25 '23 19:05 camipacifici

Codecov Report

Patch and project coverage have no change.

Comparison is base (390bf9f) 91.60% compared to head (13dd54b) 91.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2217   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         148      148           
  Lines       16494    16494           
=======================================
  Hits        15109    15109           
  Misses       1385     1385           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 25 '23 19:05 codecov[bot]