jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Cubeviz to use wcs1d-fits from specutils to write out fitted cube

Open pllim opened this issue 1 year ago • 4 comments

Description

This pull request is to remove the unreleased jdaviz-cube writer we added in #2012 and use the improved specutils wcs1d-fits writer that Derek modifed in https://github.com/astropy/specutils/pull/1009 .

Close #2044

Blocked by

  • [x] wcs1d-fits encounters error with bool mask, so need https://github.com/astropy/specutils/pull/1051
  • [ ] Update specutils pin again when https://github.com/astropy/specutils/pull/1051 is released (>1.10)
  • [x] https://github.com/astropy/specutils/pull/1009 and the fix above need to be released and then we have to update minversion pin for specutils.
  • [x] If this PR does not make it to jdaviz v3.4, we also need to modify change log (and doc?) to withdraw a released feature.

Change log entry

  • [x] Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts, list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • [x] Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • [ ] Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • [x] Do the proposed changes follow the STScI Style Guides?
  • [x] Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • [x] Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • [ ] Did the CI pass? If not, are the failures related?
  • [x] Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • [ ] After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

pllim avatar Mar 17 '23 20:03 pllim