jdaviz icon indicating copy to clipboard operation
jdaviz copied to clipboard

Published 20 hours ago • verified publisher icon spacetelescope

Move region/Subset translation code to glue-astronomy

Open Jdaviz-Triage-Bot opened this issue 3 years ago • 2 comments

Reporter: pllim

This is a follow-up of https://github.com/spacetelescope/jdaviz/pull/1463 . In that PR, because it was blocking something else and we needed a fast turnaround time, some code that could have been in glue-astronomy were added straight into Jdaviz. I am talking about the regions2roi function in jdaviz/core/region_translators.py module. It is better to move that code to glue-astronomy so more people can benefit from the generic translation tools.

So a few things we need to do:

  • [ ] Move that code to glue-astronomy. Get that released upstream.
  • [ ] Use the released glue-astronomy code in Jdaviz, deprecate the equivalent code in Jdaviz.
  • [ ] After a few major Jdaviz releases, remove the deprecated code from Jdaviz codebase.

This probably will drag on for a while and the items above should be sub-tasks.

🐱

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

Jdaviz-Triage-Bot avatar Aug 12 '22 22:08 Jdaviz-Triage-Bot