gwcs icon indicating copy to clipboard operation
gwcs copied to clipboard

Respect the bounding_box in inverse transforms

Open nden opened this issue 1 year ago • 3 comments

Fixes #496

This is a fix similar in spirit to #497 though it uses methods of modeling.ModelBoundingBox .

nden avatar May 14 '24 16:05 nden

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (9cd8552) to head (08bafd0). Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/wcs.py 92.85% 5 Missing :warning:
gwcs/api.py 60.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   87.42%   87.50%   +0.08%     
==========================================
  Files          22       22              
  Lines        3874     3931      +57     
==========================================
+ Hits         3387     3440      +53     
- Misses        487      491       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 14 '24 16:05 codecov[bot]

@bmorris3 Do you mind testing this PR with your code? Since this changes the functionality, there are a number of failures in the jwst pipeline. I'll need to address them before this is merged or make this the non-default behavior.

nden avatar May 14 '24 21:05 nden

@Cadair Can you take a look at this PR and see if it's OK for sun related code? Note that enforcing the bounding_box on the inverse transform now works and this can change results. If reproducing the bug is necessary, a parameter should be passed with_bounding_box=False.

nden avatar May 17 '24 15:05 nden