drizzlepac icon indicating copy to clipboard operation
drizzlepac copied to clipboard

Add Windows to CI and build

Open pllim opened this issue 1 month ago • 3 comments

This PR addresses the demands from Windows users.

Checklist for maintainers

  • [ ] added entry in CHANGELOG.rst within the relevant release section
  • [ ] updated or added relevant tests
  • [ ] updated relevant documentation
  • [ ] added relevant label(s)

pllim avatar Oct 09 '25 17:10 pllim

https://github.com/spacetelescope/drizzlepac/actions/runs/18383687478/job/52376597187?pr=2091#step:9:3240 what tried to inject /Wextra here? It needs to be /W4 (-ish) instead.

    creating build\temp.win-amd64-cpython-311\Release\src
    "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -Isrc -IC:\Users\runneradmin\AppData\Local\Temp\pip-build-env-zcayg45j\overlay\Lib\site-packages\numpy\_core\include -IC:\Users\runneradmin\AppData\Local\Temp\cibw-run-j469qunb\cp311-win_amd64\venv-test\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.11.9\tools\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.11.9\tools\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\ATLMFC\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /Tcsrc\_region_filter.c /Fobuild\temp.win-amd64-cpython-311\Release\src\_region_filter.obj -Wall -Wextra -Wno-int-conversion -std=gnu99
    cl : Command line error D8021 : invalid numeric argument '/Wextra'
    error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.44.35207\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
    [end of output]

jhunkeler avatar Oct 09 '25 17:10 jhunkeler

Nevermind. Found it in stregion. https://github.com/spacetelescope/stregion/blob/385b599869fcd2a781db9e541280579e540d6863/setup.py#L23-L28

jhunkeler avatar Oct 09 '25 17:10 jhunkeler

Yeah, this PR is stemmed from

  • https://github.com/spacetelescope/stregion/issues/19

pllim avatar Oct 09 '25 17:10 pllim

I dunno what's up with the Linux failure. The concerns here is only for Windows:

  1. Might not able to do win32 because it tries to build scipy from source for some reason.
  2. There are some path handling (and maybe other bugs) that need fixing before this package is compatible with Windows, so it wasn't just blocked by stregion.

pllim avatar Nov 17 '25 18:11 pllim

Does not sound trivial to fix:

Replacing primary WCS with
	Headerlet with WCSNAME=IDC_2731450pi-HSC30
	Headerlet with WCSNAME=IDC_2731450pi-HSC30
Windows fatal exception: access violation

pllim avatar Nov 17 '25 19:11 pllim

Turns out https://github.com/spacetelescope/slitlessutils/pull/120 did not need this.

pllim avatar Nov 17 '25 20:11 pllim