drizzlepac icon indicating copy to clipboard operation
drizzlepac copied to clipboard

Drizzlepac/HAP: Fix remaining difference using logger (Logging)

Open stscijgbot-hstdp opened this issue 7 months ago • 2 comments

Issue HLA-1460 was created on JIRA by Steve Goldman:

Using the new logging paradigm, there are a number of lines in the old version of the trailer file that I could not reproduce in PR #⁠1976. Those lines may be hiding in other modules and files, as the work so far (HLA-705) was focused only on changes to runastrodriz. 

This ticket is meant to track down the rest of the necessary changes so that we fully reproduce the old version of the trailer file code, using our new logging framework. 

 

So far, there are new lines created in the trailer file as a result of proper logging of stwcs. There are some new I/O errors in stwcs related to the logging, but those are discussed in HLA-1455. 

 

In the previous version of the trailer file it also appears that identical logging lines in the aligning steps are listed in the trailer file three times. Those extra lines are removed in PR #⁠1976.

 

Some log files are now set to None in a couple locations in the trailer. It appears that some of these temporary logs are not created, but we need to decide whether these additional logs are still useful. 

 

The remaining missing lines are as follows. Lines correspond to old version of the code. The files processed were ib4606c5q_flc.fits and {}ib4606crq_flt.fits{}:

LINE 1: ########################################################################
1742235130.671765: Calibration pipeline processing of ib4606c5q_flc.fits started.
*** astrodrizzle Processing Version 3.7.1rc1.dev69+gcf3df9a0.d20250220***
    drizzlepac version 3.7.1rc1.dev69+gcf3df9a0.d20250220
    tweakwcs version 0.8.9
    stwcs version 1.7.3
    numpy version 1.26.4
    photutils version 2.2.0
2025076141228-I-----Starting alignment with bad-pixel identification------------
*** astrodrizzle Processing Version 3.7.1rc1.dev69+gcf3df9a0.d20250220***
2025076141228-I-----astrodrizzle started ---------------------------------------
*** astrodrizzle Processing Version 3.7.1rc1.dev69+gcf3df9a0.d20250220***
14:12:28 (17-Mar-2025): Processing ib4606c5q_flc.fits with astrodrizzle Version 3.7.1rc1.dev69+gcf3df9a0.d20250220


LINES 227, 449, 2131: ###########################################################
2025076141230-I-----astrodrizzle started ---------------------------------------
*** astrodrizzle Processing Version 3.7.1rc1.dev69+gcf3df9a0.d20250220***


LINES 624, 2026: ################################################################
[INFO    ] Deleting previous output product: ib4606c5q_single_sci.fits


LINES 664, 2066: ################################################################
[INFO    ] Removing previous output product...


LINE 725: ######################################################################
Adding apriori WCS solutions to ['ib4606c5q_flc.fits']
Restoring apriori WCS IDC_2731450pi-FIT_IMG_GAIAeDR3 as primary WCS in ib4606c5q_flc.fits
Verifying apriori WCSNAMEs:
   ib4606c5q_flc.fits: IDC_2731450pi-HSC30
2025076141239-I-----Align_to_GAIA started -


LINE 749: ######################################################################
Wrote ib4606c5q_flc.fits.source_catalog.pickle


LINE 756: ######################################################################
Wrote reference catalog refcatalog.cat.


LINE 760: ######################################################################
# Running configure fit for AlignmentTable to use: [WCS KeywordsNumber of WCS axes: 2
CTYPE : 'RA---TAN-SIP' 'DEC--TAN-SIP' 
CRVAL : 137.86451099462 -64.904102036038 
CRPIX : 2048.0 1026.0 
CD1_1 CD1_2  : 4.9739967461438e-06 -9.5538544978896e-06 
CD2_1 CD2_2  : -9.8882812474608e-06 -5.5867023201787e-06 
NAXIS : 4096  2051, WCS Keywords


LINES 786, 891: #################################################################FIT being evaluated for ib4606c5q_flc.fits
{'status': 'SUCCESS', 'fitgeom': 'rscale', 'eff_minobj': 12, 'matrix': array([[ 9.99885159e-01, -2.38716204e-05],


LINE 1850: #####################################################################
2025076141252-I-----Align_to_GAIA completed ------------------------------------
2025076141252-I-----astrodrizzle started ---------------------------------------
*** astrodrizzle Processing Version 3.7.1rc1.dev69+gcf3df9a0.d20250220*** ```

stscijgbot-hstdp avatar Mar 20 '25 18:03 stscijgbot-hstdp