drizzlepac icon indicating copy to clipboard operation
drizzlepac copied to clipboard

ensure extension modules are present in built wheel

Open zacharyburnett opened this issue 9 months ago • 2 comments

Resolves SCSB-149

Checklist for maintainers

  • [ ] ~added entry in CHANGELOG.rst within the relevant release section~
  • [x] updated or added relevant tests
  • [ ] updated relevant documentation
  • [x] added relevant label(s)
  • [ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

zacharyburnett avatar May 06 '24 16:05 zacharyburnett

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.42%. Comparing base (76a3e27) to head (b688ed5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
- Coverage   33.31%   31.42%   -1.89%     
==========================================
  Files         126      160      +34     
  Lines       31197    35152    +3955     
  Branches     5772        0    -5772     
==========================================
+ Hits        10392    11048     +656     
- Misses      19642    24104    +4462     
+ Partials     1163        0    -1163     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 16:05 codecov[bot]

it appears that a new release of stwcs is required in order for drizzlepac to build against Python 3.12, due to the removal of pkg_resources https://github.com/spacetelescope/drizzlepac/actions/runs/8973533525/job/24643939956#step:6:1383

ModuleNotFoundError: No module named 'pkg_resources'

zacharyburnett avatar May 06 '24 18:05 zacharyburnett

I just rebased the code and reran the CI, so it should be the same as when @mdlpstsci reviewed it; merging

zacharyburnett avatar May 10 '24 14:05 zacharyburnett