drizzlepac
drizzlepac copied to clipboard
HLA-1233: Updated configuration files to use fitgeom='rshift' and minobj=10
Resolves HLA-1233
Closes #1763
This PR updates the configuration files to use the 'rshift' fitgeom instead of 'rscale'. It also increases the minimum number of identified objects from each input image to use in matching objects from 6 to 10 for the default ('rshift') fitgeom. The fitgeom='shift' options has also been removed from the matrix of fits for HAP.
Checklist for maintainers
- [x] added entry in
CHANGELOG.rstwithin the relevant release section - [x] updated or added relevant tests
- [x] updated relevant documentation
- [x] added relevant milestone
- [x] added relevant label(s)
- [x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 31.49%. Comparing base (
5a868ad) to head (f40625d). Report is 24 commits behind head on main.
:exclamation: Current head f40625d differs from pull request most recent head 491054d
Please upload reports for the commit 491054d to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #1769 +/- ##
==========================================
- Coverage 34.47% 31.49% -2.99%
==========================================
Files 127 159 +32
Lines 31209 35139 +3930
Branches 5772 0 -5772
==========================================
+ Hits 10759 11066 +307
- Misses 19252 24073 +4821
+ Partials 1198 0 -1198
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Holding off on merging this until the instrument scientists have a chance to test the code.
@s-goldman Please make sure Jenn and Rick know this code is available for testing -- tag them in this ticket or the JIRA ticket so they do not forget.
@s-goldman
I often forget to do this, but please ask Jenn for a dataset which you can test yourself and observe the differences with regard to the changes you have made. Perhaps you have already done this and just did not document the test here. If so, please ignore this comment. However, as noted above, please ask Jenn and/or Rick to do a test also.