drizzlepac icon indicating copy to clipboard operation
drizzlepac copied to clipboard

Is exptime weighting not applied when input weight image is None?

Open mcara opened this issue 1 year ago • 2 comments
trafficstars

Please refer to:

https://github.com/spacetelescope/drizzlepac/blob/ed40f611bf9bc040485493a79ed0beae70e3c131/src/cdrizzlebox.c#L554-L560

It looks like when input weight image is not provided, exptime or expsq scaling is not performed and all images are weighted equally. This unexpected (to me).

mcara avatar Jan 18 '24 14:01 mcara

This issue is tracked on JIRA as HLA-1184.

stscijgbot-hstdp avatar Jan 18 '24 14:01 stscijgbot-hstdp

This seems to make perfect sense to me. Weights are hard-coded in drizzlepac to be provided under all circumstances (see lines 898-905 in drizzlepac\adrizzle.py) and provide the exptime or IVM weights on input to this C code. Also, if no weights are provided on input, the code has no other information to use to weight the images, so weighting them equally makes as much sense as anything. At least, that behavior is predictable and explainable.

stsci-hack avatar Jan 23 '24 19:01 stsci-hack