drizzlepac icon indicating copy to clipboard operation
drizzlepac copied to clipboard

Remove use of astroquery from drizzlepac

Open mdlpstsci opened this issue 2 years ago • 1 comments

Use of the astroquery package via the drizzlepac astroquery_utils module has been removed. As observed in other spacetelescope packages, a conflict between astroquery and Artifactory caused PyTests to fail in an inexplicable way. The PyTests have been modified to use Artifactory. The few PyTests which deliberately have their datasets defined based on a randomly selected dataset from an input file have been set to skip. These tests were used to derive statistics on the success rate of alignment for single visits, so they really are deprecated pieces of code. Bits of other modules in drizzlepac had to be modified to accommodate the removal of astroquery.

The pyproject.toml file was modified to force an upper limit on the Numpy version until incompatible issues can be resolved.

mdlpstsci avatar Jul 05 '23 20:07 mdlpstsci

Codecov Report

Patch coverage: 40.74% and project coverage change: -1.06% :warning:

Comparison is base (8d09dda) 32.39% compared to head (c0f726f) 31.34%. Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
- Coverage   32.39%   31.34%   -1.06%     
==========================================
  Files         159      156       -3     
  Lines       35047    34391     -656     
  Branches        0     5624    +5624     
==========================================
- Hits        11355    10779     -576     
+ Misses      23692    22524    -1168     
- Partials        0     1088    +1088     
Files Changed Coverage Δ
drizzlepac/align.py 66.60% <0.00%> (+17.72%) :arrow_up:
drizzlepac/haputils/poller_utils.py 48.64% <0.00%> (-3.43%) :arrow_down:
tests/hap/base_classes.py 48.64% <0.00%> (+0.59%) :arrow_up:
tests/hap/template_svm_demo.py 0.00% <0.00%> (ø)
tests/hap/test_pipeline.py 10.52% <14.28%> (-81.69%) :arrow_down:
tests/hap/test_apriori.py 21.42% <33.33%> (+0.46%) :arrow_up:
tests/hap/test_run_svmpoller.py 22.80% <50.00%> (-12.20%) :arrow_down:
tests/hap/test_svm_hrcsbc.py 36.84% <66.66%> (-54.47%) :arrow_down:
tests/hap/test_svm_ibqk07.py 31.37% <66.66%> (-64.11%) :arrow_down:
tests/hap/test_svm_ibyt50.py 37.06% <66.66%> (-57.22%) :arrow_down:
... and 6 more

... and 55 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 05 '23 20:07 codecov[bot]