astronify icon indicating copy to clipboard operation
astronify copied to clipboard

Handle clipping

Open ceb8 opened this issue 5 years ago • 3 comments
trafficstars

It's possible and in fact too easy to overwhelm the speaker and get unpleasant sounds, we need to implement automatic clipping so this can't happen.

ceb8 avatar May 05 '20 19:05 ceb8

This may be handled by #17

tsdower avatar Jun 03 '20 21:06 tsdower

I think it's handled from a practical level by https://github.com/spacetelescope/astronify/pull/17, but I'm still hoping to be able to find a setting in pyo where this can happen automatically so the user doesn't have to play around and figure out the correct gain for their system. So I'm going to leave this issue open for now.

ceb8 avatar Jun 09 '20 14:06 ceb8

Removing the MVP label because @theresadower's work as definitely fixed the issue well enough for initial release.

ceb8 avatar Jun 09 '20 14:06 ceb8