go-spacemesh

go-spacemesh copied to clipboard

## Motivation We could run [staticcheck](https://staticcheck.io) linter in CI to catch common mistakes, bugs, unused code etc. Closes #3576 ## Changes - run statickcheck in _quicktests_ job in CI -...

poszu

cmd/node: configuration changes for genesis id

3

## Motivation Closes #3505 ## Changes Adds a genesis section into config. ## DevOps Notes - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM...

evt

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.1 to 0.25.2. Commits 593f096 Update dependencies to v0.25.2 tag See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR...

dependabot[bot]

Size of messages in hare protocol are too large for P2P network (esp. SVP)

1

Listed some potential issues to address once we run the hare protocol on a large scale. The protocol specifies running that hare with committees of size N= 800, and so...

barakshani

Propagation of messages for the wrong round of Hare

3

We should consider not propagating hare messages with layer/round which are not correct (not current or _early_)

barakshani

Consider optimizing proposal validation to the end of the round

1

We can validate the SVP at the end of the proposal round. Pros: No need to validate multiple proposals, only the lowest. Cons An SVP is relatively expensive to validate.

gavraz

Current ticker used for round intervals may skip rounds

4

Round events (ticks) that are not handled (pulled) on time (before the next tick) causes the ticker to drop the tick. Hence, we might miss the round that follows the...

gavraz

Broker allows early messages for type != PreRound

2

The broker shouldn't allow messages that are not PreRound to be considered as early messages. The only reason we allow it, for now, is because of tests. Some tests may...

gavraz

Hare broker buffer for early messages is unlimited

2

The buffer for early messages is limited. Upon reaching the buffer limit, the consensus process associated with this buffer is canceled and the messages are dropped. The vulnerability is that...

gavraz

PreRound union is unlimited

2

Receiving multiple PreRound messages from the same sender is currently handled by calculating the union of the pre-round sets. A malicious node can send multiple pre-round messages in which the...

gavraz